-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace @bazel_tools//platforms with @platforms//os #2249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reports that their build file generation takes longer than 600 seconds. It's probably a bug that we are so slow, but let's address that separately (maybe in our work for npm v7) Also note we could have made this timeout user-configurable, but I think the extra API surface isn't worth the benefit. Fixes bazel-contrib#2231
Tested by building //packages/angular:npm_package and don't get an extra .d.ts file in the package. Also tested the negative case by making an invalid option and check that it's still reported. Fixes bazel-contrib#2078
* docs: minor update for readibility and formating
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
October 22, 2020 02:09
alexeagle
force-pushed
the
use_platforms_repo
branch
from
October 26, 2020 14:02
d909437
to
0a2de87
Compare
Also recommend ts_project for new uses
Bazel is changing how @bazel_tools/conditions:darwin is implemented. With old implementation based on flags, it was ok to have darwin and darwin_x86_64 in a select. This was based on flag --cpu=darwin and --cpu=dawin_x86_64. New implementation is based on constraints, where "darwin" means OS (and any CPU), while "darwin_x86_64" mean only specific CPU. As such they cannot be used in the same select, because the selection would be ambiguous.
Will revisit the linker and test, but this is blocking PRs from being merged
* feat(typescript): worker mode for ts_project * chore: cleanup and declare protobufjs dependency * fix: do not pass --watch for non-worker mode * fix: do not test worker on windows * fix: log on standalone failures * chore: docs improvements Co-authored-by: Alex Eagle <[email protected]> Co-authored-by: Dan Muller <[email protected]>
Also allow non-ts files across src/bin dir, since they are not emitted we don't need the rootdir calculation to take them into account. This lets the Angular compiler accept .ts sources from source dir even if the css inputs are generated.
alexeagle
force-pushed
the
use_platforms_repo
branch
from
November 10, 2020 19:12
0a2de87
to
3e834ec
Compare
Current link returns 404, it seems that the url was somehow changed to .html from .md.
…& fix link_workspace_root with no runfiles
It was using a non-standard repository, which had downtime this morning
Example how this looks now: ``` [20 / 21] Bundling JavaScript bundle.js [parcel]; 4s remote-cache, darwin-sandbox ERROR: /private/var/folders/r7/2kp53v7n091gcz93xlt7wtd80000gn/T/tmp-48948DHy4HrXTwhRy/BUILD.bazel:4:1: Bundling JavaScript bundle.js [parcel] failed (Exit 1) parcel.sh failed: error executing command bazel-out/host/bin/external/npm/parcel-bundler/bin/parcel.sh build foo.js --out-dir bazel-out/darwin-fastbuild/bin --out-file bundle.js ... (remaining 2 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox ERROR: rules_nodejs linker requires Node v10 or greater, but is running on 8.11.2 Note that earlier Node versions are no longer in long-term-support, see https://nodejs.org/en/about/releases/ INFO: Elapsed time: 40.360s, Critical Path: 12.97s INFO: 0 processes. FAILED: Build did NOT complete successfully //:test NO STATUS ``` Fixes bazel-contrib#2304
chore: allow node versions >=12 <=14
… to npm_package_bin driven actions (bazel-contrib#2353)
NPM tools are currently run out of external/{md}/node_modules. If the tool loads user-provided files in the execroot, which is the common case, then this can lead to bad interactions. Two examples of bad interactions are: 1. A tool that loads React and the user code too, hooks becoming unusable. 2. A tool that calls into a bundler like Webpack, potentially bundling duplicate packages. Signed-off-by: Duarte Nunes <[email protected]>
…mples See bazelbuild/bazel#8622 This is an expected breaking change in Bazel 4.0
alexeagle
force-pushed
the
use_platforms_repo
branch
from
December 18, 2020 15:30
3e834ec
to
652e383
Compare
12 tasks
replaced with #2536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable incompatible_use_platforms_repo_for_constraints for examples
See bazelbuild/bazel#8622
This is an expected breaking change in Bazel 4.0
It seems like we need to update rules_go in order to turn on the flag for our own build, still TODO